[ 
https://issues.apache.org/jira/browse/CASSANDRA-714?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12854891#action_12854891
 ] 

Todd Blose edited comment on CASSANDRA-714 at 4/9/10 11:10 AM:
---------------------------------------------------------------

Ok, since this change involves several areas of the code, across multiple 
tickets, I'm limiting the scope of the patch for now.

the keyspace argument has been removed from the thrift methods. I regenerated 
the thrift code and updated CassandraServer to use a new keyspace thread local. 

I left CASSANDRA-718 alone, but it is trivial to resolve now with this patch.

Here are some remaining issues:

* There are errors in cassandra-cli. These cannot be resolved until 
CASSANDRA-859 is addressed.

* test_thrift_server.py needs updated.

* login will be necessary in hadoop.ColumnFamilyRecordReader now.

I didn't want to make too many changes within a single patch. Should each be 
addressed separately and all patches merged together, or what is the best 
procedure?

      was (Author: todd):
    Initial patch was done incorrectly. Will submit fixed version shortly.
  
> remove keyspace argument from thrift methods
> --------------------------------------------
>
>                 Key: CASSANDRA-714
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-714
>             Project: Cassandra
>          Issue Type: Improvement
>          Components: Core
>    Affects Versions: 0.6
>            Reporter: Eric Evans
>             Fix For: 0.7
>
>         Attachments: CASSANDRA-714.patch
>
>
> With the completion of CASSANDRA-547, the keyspace can be specified as part 
> of the login and stored in a thread-local. This will allow us to remove the 
> wasteful and redundant mandatory keyspace argument on all of the other rpc 
> methods.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to