[ https://issues.apache.org/jira/browse/CASSANDRA-8647?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14283996#comment-14283996 ]
Jonathan Ellis commented on CASSANDRA-8647: ------------------------------------------- Code LGTM. I'd just request a comment that we're delaying the local read until the end to avoid blocking non-local messages. > Unify ARR#makeDataRequests() and ARR#makeDigestRequests() > --------------------------------------------------------- > > Key: CASSANDRA-8647 > URL: https://issues.apache.org/jira/browse/CASSANDRA-8647 > Project: Cassandra > Issue Type: Bug > Reporter: Aleksey Yeschenko > Assignee: Aleksey Yeschenko > Priority: Trivial > Fix For: 2.1.3 > > Attachments: 8647.txt > > > Two methods should be essentially the same, yet CASSANDRA-4718 gave > madeDataRequests() some preferential treatment - confusing at least one > person in the process. > The attached patch cleans up and unifies both methods. > Will not include in CHANGES.txt. -- This message was sent by Atlassian JIRA (v6.3.4#6332)