[
https://issues.apache.org/jira/browse/CASSANDRA-7066?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14514415#comment-14514415
]
Benedict commented on CASSANDRA-7066:
-------------------------------------
It is probably best to work from 8984-alt, since that is basically final except
for some expansion of unit test coverage.
The SSTableDeletingTask complication I hadn't previously considered, but there
are two ways around this:
# Have a shared object that each deleting task decrements a counter within, and
once the counter reaches zero we delete the log file;
# Immediately write a new component file against each sstable marking it as
deleted, and delete this file along with the other components in
SSTableDeletingTask
bq. any issues on upgrading from old cassandra versions?
Worst case scenario is some duplicated sstable data. Interestingly on DRAIN we
don't cancel any in-progress transactions. Perhaps we should, to ensure that
these are cleaned up for us anyway, so that an operator going through correct
upgrade procedure should never encounter even this hiccup.
Otherwise everything sounds good to me.
> Simplify (and unify) cleanup of compaction leftovers
> ----------------------------------------------------
>
> Key: CASSANDRA-7066
> URL: https://issues.apache.org/jira/browse/CASSANDRA-7066
> Project: Cassandra
> Issue Type: Improvement
> Components: Core
> Reporter: Benedict
> Assignee: Stefania
> Priority: Minor
> Labels: compaction
> Fix For: 3.0
>
>
> Currently we manage a list of in-progress compactions in a system table,
> which we use to cleanup incomplete compactions when we're done. The problem
> with this is that 1) it's a bit clunky (and leaves us in positions where we
> can unnecessarily cleanup completed files, or conversely not cleanup files
> that have been superceded); and 2) it's only used for a regular compaction -
> no other compaction types are guarded in the same way, so can result in
> duplication if we fail before deleting the replacements.
> I'd like to see each sstable store in its metadata its direct ancestors, and
> on startup we simply delete any sstables that occur in the union of all
> ancestor sets. This way as soon as we finish writing we're capable of
> cleaning up any leftovers, so we never get duplication. It's also much easier
> to reason about.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
