[ https://issues.apache.org/jira/browse/CASSANDRA-7066?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14523179#comment-14523179 ]
Joshua McKenzie commented on CASSANDRA-7066: -------------------------------------------- If we stick with the tmp files approach that's going to add complexity to the SSTableRewriter story on Windows once we start work on memory-mapped files. We're weighing a guaranteed increase in complexity (not memory-mapping segments during rewrite until final write completes for instance) and risk (tmp files staying around) vs. a potential loss of clarity and flexibility on non-standard operations (users copying files around manually). I don't think it's worth it to keep it, personally. As [~benedict] pointed out - we give people tools so they shouldn't have to muck around with their raw files manually. > Simplify (and unify) cleanup of compaction leftovers > ---------------------------------------------------- > > Key: CASSANDRA-7066 > URL: https://issues.apache.org/jira/browse/CASSANDRA-7066 > Project: Cassandra > Issue Type: Improvement > Components: Core > Reporter: Benedict > Assignee: Stefania > Priority: Minor > Labels: compaction > Fix For: 3.x > > > Currently we manage a list of in-progress compactions in a system table, > which we use to cleanup incomplete compactions when we're done. The problem > with this is that 1) it's a bit clunky (and leaves us in positions where we > can unnecessarily cleanup completed files, or conversely not cleanup files > that have been superceded); and 2) it's only used for a regular compaction - > no other compaction types are guarded in the same way, so can result in > duplication if we fail before deleting the replacements. > I'd like to see each sstable store in its metadata its direct ancestors, and > on startup we simply delete any sstables that occur in the union of all > ancestor sets. This way as soon as we finish writing we're capable of > cleaning up any leftovers, so we never get duplication. It's also much easier > to reason about. -- This message was sent by Atlassian JIRA (v6.3.4#6332)