[
https://issues.apache.org/jira/browse/CASSANDRA-8384?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14615547#comment-14615547
]
Benjamin Lerer commented on CASSANDRA-8384:
-------------------------------------------
I had a look, but moving {{crc_check_chance}} out of the compression options is
not straight forward. So, I prefer if we address it in another ticket.
I fixed the review comments and implemented some of the refactoring discussed
off line with [~iamaleksey].
The branch is
[here|https://github.com/apache/cassandra/compare/trunk...blerer:8384]
> Change CREATE TABLE syntax for compression options
> --------------------------------------------------
>
> Key: CASSANDRA-8384
> URL: https://issues.apache.org/jira/browse/CASSANDRA-8384
> Project: Cassandra
> Issue Type: Sub-task
> Reporter: Aleksey Yeschenko
> Assignee: Benjamin Lerer
> Labels: doc-impacting, docs
> Fix For: 3.x
>
>
> Currently, `compression` table options are inconsistent with the likes of it
> (table `compaction`, keyspace `replication`).
> I suggest we change it for 3.0, like we did change `caching` syntax for 2.1
> (while continuing to accept the old syntax for a release).
> I recommend the following changes:
> 1. rename `sstable_compression` to `class`, to make it consistent
> `compression` and `replication`
> 2. rename `chunk_length_kb` to `chunk_length_in_kb`, to match
> `memtable_flush_period_in_ms`, or, alternatively, to just `chunk_length`,
> with `memtable_flush_period_in_ms` renamed to `memtable_flush_period` -
> consistent with every other CQL option everywhere else
> 3. add a boolean `enabled` option, to match `compaction`. Currently, the
> official way to disable comression is an ugly, ugly hack (see CASSANDRA-8288)
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
