[
https://issues.apache.org/jira/browse/CASSANDRA-7066?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14696634#comment-14696634
]
Benedict commented on CASSANDRA-7066:
-------------------------------------
bq. I did not switch the hard failure flag to true for any clients except for
the new sstableutil tool. I am not sure which ones are good candidates, perhaps
all standalone tools or when we read the snapshot directories?
I more meant for this to be the _default_ behaviour (particularly for
{{Directories}}) so that any consumers that don't consider this and set the
appropriate flag can be informed of their mistake (eventually). Ignoring errors
should be a consciously opted into decision. Of course, we could just hard fail
the {{Directories}} list immediately if such a flag hasn't been set, and
perhaps that's a better option still.
I think it would also be better for this behaviour to be defined as an enum as
opposed to a boolean flag.
Otherwise LGTM. Thanks!
> Simplify (and unify) cleanup of compaction leftovers
> ----------------------------------------------------
>
> Key: CASSANDRA-7066
> URL: https://issues.apache.org/jira/browse/CASSANDRA-7066
> Project: Cassandra
> Issue Type: Improvement
> Components: Core
> Reporter: Benedict
> Assignee: Stefania
> Priority: Minor
> Labels: benedict-to-commit, compaction
> Fix For: 3.0 alpha 1
>
> Attachments: 7066.txt
>
>
> Currently we manage a list of in-progress compactions in a system table,
> which we use to cleanup incomplete compactions when we're done. The problem
> with this is that 1) it's a bit clunky (and leaves us in positions where we
> can unnecessarily cleanup completed files, or conversely not cleanup files
> that have been superceded); and 2) it's only used for a regular compaction -
> no other compaction types are guarded in the same way, so can result in
> duplication if we fail before deleting the replacements.
> I'd like to see each sstable store in its metadata its direct ancestors, and
> on startup we simply delete any sstables that occur in the union of all
> ancestor sets. This way as soon as we finish writing we're capable of
> cleaning up any leftovers, so we never get duplication. It's also much easier
> to reason about.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
