[ https://issues.apache.org/jira/browse/CASSANDRA-7066?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14661942#comment-14661942 ]
Yuki Morishita commented on CASSANDRA-7066: ------------------------------------------- Found this while I was looking at CASSANDRA-10006. I think we should be more careful when migrating to new format here (https://github.com/stef1927/cassandra/blob/7066-b/src/java/org/apache/cassandra/db/SystemKeyspace.java#L1298). {{Descriptor.isLegacyFile}}(https://github.com/stef1927/cassandra/blob/7066-b/src/java/org/apache/cassandra/io/sstable/Descriptor.java#L170) just checks if given file/directory name begin with certain keyword ("compaction_in_progress", "tmp", tmplink"), this may accidentally delete user table that starts with, say, "tmp". I suggest we add more strict check here. > Simplify (and unify) cleanup of compaction leftovers > ---------------------------------------------------- > > Key: CASSANDRA-7066 > URL: https://issues.apache.org/jira/browse/CASSANDRA-7066 > Project: Cassandra > Issue Type: Improvement > Components: Core > Reporter: Benedict > Assignee: Stefania > Priority: Minor > Labels: benedict-to-commit, compaction > Fix For: 3.0 alpha 1 > > Attachments: 7066.txt > > > Currently we manage a list of in-progress compactions in a system table, > which we use to cleanup incomplete compactions when we're done. The problem > with this is that 1) it's a bit clunky (and leaves us in positions where we > can unnecessarily cleanup completed files, or conversely not cleanup files > that have been superceded); and 2) it's only used for a regular compaction - > no other compaction types are guarded in the same way, so can result in > duplication if we fail before deleting the replacements. > I'd like to see each sstable store in its metadata its direct ancestors, and > on startup we simply delete any sstables that occur in the union of all > ancestor sets. This way as soon as we finish writing we're capable of > cleaning up any leftovers, so we never get duplication. It's also much easier > to reason about. -- This message was sent by Atlassian JIRA (v6.3.4#6332)