[ 
https://issues.apache.org/jira/browse/CASSANDRA-10580?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15042324#comment-15042324
 ] 

Paulo Motta commented on CASSANDRA-10580:
-----------------------------------------

Thanks for the patch. Can you please rebase/merge to latest 2.1 HEAD? Some 
comments:
- use debug level instead of warn in order not to pollute system.log, and not 
to scare away users, since dropping mutations is part of the normal load 
shedding mechanism. In 2.2 all debug level logging will go to debug.log file.
- print only keyspace and table name, as logging the whole mutation might 
reveal sensitive information in logs

> On dropped mutations, more details should be logged.
> ----------------------------------------------------
>
>                 Key: CASSANDRA-10580
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-10580
>             Project: Cassandra
>          Issue Type: Improvement
>          Components: Coordination
>         Environment: Production
>            Reporter: Anubhav Kale
>            Assignee: Anubhav Kale
>            Priority: Minor
>             Fix For: 2.1.x
>
>         Attachments: CASSANDRA-10580-Head.patch
>
>
> In our production cluster, we are seeing a large number of dropped mutations. 
> At a minimum, we should print the time the thread took to get scheduled 
> thereby dropping the mutation (We should also print the Message / Mutation so 
> it helps in figuring out which column family was affected). This will help 
> find the right tuning parameter for write_timeout_in_ms. 
> The change is small and is in StorageProxy.java and MessagingTask.java. I 
> will submit a patch shortly.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to