[ 
https://issues.apache.org/jira/browse/CASSANDRA-10580?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15049582#comment-15049582
 ] 

Paulo Motta commented on CASSANDRA-10580:
-----------------------------------------

I mean in this statement:
{code:java}
                logger.warn("LocalMutationRunnable thread ran after {} ms, 
allowed time was {} ms. Dropping mutation. "
                                + "Keyspace {}, Column Family Ids {}", 
                                timeTaken, mutationTimeout, 
                                this.mutation.getKeyspaceName(), 
Arrays.toString(this.mutation.getColumnFamilyIds().toArray()));
{code}

If {{this.mutation == null}} then {{NullPointerException}} will be thrown, so 
we need to handle that (sorry I was not clear before).

> On dropped mutations, more details should be logged.
> ----------------------------------------------------
>
>                 Key: CASSANDRA-10580
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-10580
>             Project: Cassandra
>          Issue Type: Improvement
>          Components: Coordination
>         Environment: Production
>            Reporter: Anubhav Kale
>            Assignee: Anubhav Kale
>            Priority: Minor
>             Fix For: 3.2, 2.2.x
>
>         Attachments: 10580.patch, CASSANDRA-10580-Head.patch
>
>
> In our production cluster, we are seeing a large number of dropped mutations. 
> At a minimum, we should print the time the thread took to get scheduled 
> thereby dropping the mutation (We should also print the Message / Mutation so 
> it helps in figuring out which column family was affected). This will help 
> find the right tuning parameter for write_timeout_in_ms. 
> The change is small and is in StorageProxy.java and MessagingTask.java. I 
> will submit a patch shortly.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to