[
https://issues.apache.org/jira/browse/CASSANDRA-13964?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16227375#comment-16227375
]
Sam Tunnicliffe commented on CASSANDRA-13964:
---------------------------------------------
[~jasobrown] thanks for the review & sorry for the delay in getting back to
this.
You're totally right about the dtest, [so I've made it sane as you
suggested|https://github.com/beobal/cassandra-dtest/commit/edc48bc965e842628413cfd50a7a21071d7b098a].
As the upstream branches have moved on in since you reviewed, I've rebased &
force pushed to trigger CI to run again. The addition of CASSANDRA-13291 to
trunk was no issue as both branches took the same approach. Unless you have any
concerns, I'll commit once CI is done. Thanks.
||branch||utest||dtest||
|[13964-3.0|https://github.com/beobal/cassandra/tree/13964-3.0]|[utest|https://circleci.com/gh/beobal/cassandra/tree/13964-3.0]|[dtest|https://builds.apache.org/view/A-D/view/Cassandra/job/Cassandra-devbranch-dtest/401/]|
|[13964-3.11|https://github.com/beobal/cassandra/tree/13964-3.11]|[utest|https://circleci.com/gh/beobal/cassandra/tree/13964-3.11]|[dtest|https://builds.apache.org/view/A-D/view/Cassandra/job/Cassandra-devbranch-dtest/402/]|
|[13964-trunk|https://github.com/beobal/cassandra/tree/13964-trunk]|[utest|https://circleci.com/gh/beobal/cassandra/tree/13964-trunk]|[dtest|https://builds.apache.org/view/A-D/view/Cassandra/job/Cassandra-devbranch-dtest/403/]|
> Tracing interferes with digest requests when using RandomPartitioner
> --------------------------------------------------------------------
>
> Key: CASSANDRA-13964
> URL: https://issues.apache.org/jira/browse/CASSANDRA-13964
> Project: Cassandra
> Issue Type: Bug
> Components: Local Write-Read Paths, Observability
> Reporter: Sam Tunnicliffe
> Assignee: Sam Tunnicliffe
>
> A {{ThreadLocal<MessageDigest>}} is used to generate the MD5 digest when a
> replica serves a read command and the {{isDigestQuery}} flag is set. The same
> threadlocal is also used by {{RandomPartitioner}} to decorate partition keys.
> So in a cluster with RP, if tracing is enabled the data digest is corrupted
> by the partitioner making tokens for the tracing mutations. This causes a
> digest mismatch on the coordinator, triggering a full data read on every read
> where CL > 1 (or speculative execution/read repair kick in).
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
