[
https://issues.apache.org/jira/browse/CASSANDRA-13964?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16241998#comment-16241998
]
ASF GitHub Bot commented on CASSANDRA-13964:
--------------------------------------------
GitHub user beobal opened a pull request:
https://github.com/apache/cassandra-dtest/pull/10
Add test for digest requests with RandomPartitioner and tracing enabled
Patch by Sam Tunnicliffe; reviewed by Jason Brown for CASSANDRA-13964
@ptnapoleon: Jason already gave this the once over, but if you have chance
I'd appreciate your +1
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/beobal/cassandra-dtest 13964
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cassandra-dtest/pull/10.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #10
----
commit edc48bc965e842628413cfd50a7a21071d7b098a
Author: Sam Tunnicliffe <s...@beobal.com>
Date: 2017-10-17T13:50:25Z
Add test for digest requests with RandomPartitioner and tracing enabled
Patch by Sam Tunnicliffe; reviewed by Jason Brown for CASSANDRA-13964
----
> Tracing interferes with digest requests when using RandomPartitioner
> --------------------------------------------------------------------
>
> Key: CASSANDRA-13964
> URL: https://issues.apache.org/jira/browse/CASSANDRA-13964
> Project: Cassandra
> Issue Type: Bug
> Components: Local Write-Read Paths, Observability
> Reporter: Sam Tunnicliffe
> Assignee: Sam Tunnicliffe
>
> A {{ThreadLocal<MessageDigest>}} is used to generate the MD5 digest when a
> replica serves a read command and the {{isDigestQuery}} flag is set. The same
> threadlocal is also used by {{RandomPartitioner}} to decorate partition keys.
> So in a cluster with RP, if tracing is enabled the data digest is corrupted
> by the partitioner making tokens for the tracing mutations. This causes a
> digest mismatch on the coordinator, triggering a full data read on every read
> where CL > 1 (or speculative execution/read repair kick in).
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
