[ 
https://issues.apache.org/jira/browse/CASSANDRA-14092?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16343619#comment-16343619
 ] 

Vincent White commented on CASSANDRA-14092:
-------------------------------------------

I haven't had a chance to completely catch up on the ML discussion but I 
thought I would post a proof of concept branch I had that promotes 
localDeletionTime to long on trunk. The code definitely isn't meant to be a 
final product but it might be a useful starting point regardless of whether we 
actually decide to go this route or not. It's fairly straight forward and 
unfortunately most of the code went towards undoing optimizations introduced to 
tombstone histograms in CASSANDRA-13444. I put together the majority of this 
last year so I may be forgetting some glaring issues but I believe it was 
basically complete minus a few unit tests to be cleaned up and tools updated.

One outstanding issue I do recall is related to EXPIRED_LIVENESS_TTL which is 
currently Integer.MAX_VALUE but sounds like that should be resolved/removed at 
some point by CASSANDRA-13826.
||trunk||
|[branch|https://github.com/vincewhite/cassandra/commit/364f9ac848ae54eae9a1360d72aad4ba0a2b63a8]|

> Max ttl of 20 years will overflow localDeletionTime
> ---------------------------------------------------
>
>                 Key: CASSANDRA-14092
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-14092
>             Project: Cassandra
>          Issue Type: Bug
>          Components: Core
>            Reporter: Paulo Motta
>            Assignee: Paulo Motta
>            Priority: Blocker
>             Fix For: 2.1.20, 2.2.12, 3.0.16, 3.11.2
>
>
> CASSANDRA-4771 added a max value of 20 years for ttl to protect against [year 
> 2038 overflow bug|https://en.wikipedia.org/wiki/Year_2038_problem] for 
> {{localDeletionTime}}.
> It turns out that next year the {{localDeletionTime}} will start overflowing 
> with the maximum ttl of 20 years ({{System.currentTimeMillis() + ttl(20 
> years) > Integer.MAX_VALUE}}), so we should remove this limitation.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org

Reply via email to