[
https://issues.apache.org/jira/browse/CASSANDRA-14417?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16475563#comment-16475563
]
Marcus Eriksson commented on CASSANDRA-14417:
---------------------------------------------
pushed a new commit addressing the comments:
https://github.com/krummas/cassandra/commits/marcuse/14417
bq. In Verifier, is it more appropriate to favor OutputHandler#output over
OutputHandler#debug for the error message when a key is out of range?
yeah, made it {{OutputHandler#warn}}
bq. Would like to see some tests (including base/empty case, edge cases like
wrap around) for {{RangeOwnHelper}}
added, also made it clearer that ROH can't continue to be used after finding an
out-of-range token by making it throw exceptions instead of returning true/false
Also refactored {{Verifier}} to use a {{KeyIterator}} instead of manually
deserializing the index when checking keys.
> nodetool import cleanup/fixes
> -----------------------------
>
> Key: CASSANDRA-14417
> URL: https://issues.apache.org/jira/browse/CASSANDRA-14417
> Project: Cassandra
> Issue Type: Improvement
> Reporter: Marcus Eriksson
> Assignee: Marcus Eriksson
> Priority: Major
> Fix For: 4.x
>
>
> * We shouldn't expose importNewSSTables in both StorageServiceMBean and
> CFSMbean
> * Allow a quicker token check without doing an extended verify
> * Introduce an ImportOptions class to avoid passing in 100 booleans in
> importNewSSTables
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
