[ https://issues.apache.org/jira/browse/CASSANDRA-14417?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16476922#comment-16476922 ]
Marcus Eriksson commented on CASSANDRA-14417: --------------------------------------------- bq. While cleaning things up, should ColumnFamilyStore#findBestDiskAndInvalidateCaches be refactored to use KeyIterator as well? yep! nice catch bq. : Also, just noticed the failing dtest. yeah I should have a look, but I think it is unrelated to this pushed a new commit addressing the comments > nodetool import cleanup/fixes > ----------------------------- > > Key: CASSANDRA-14417 > URL: https://issues.apache.org/jira/browse/CASSANDRA-14417 > Project: Cassandra > Issue Type: Improvement > Reporter: Marcus Eriksson > Assignee: Marcus Eriksson > Priority: Major > Fix For: 4.x > > > * We shouldn't expose importNewSSTables in both StorageServiceMBean and > CFSMbean > * Allow a quicker token check without doing an extended verify > * Introduce an ImportOptions class to avoid passing in 100 booleans in > importNewSSTables -- This message was sent by Atlassian JIRA (v7.6.3#76005) --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org