[
https://issues.apache.org/jira/browse/CASSANDRA-14451?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16501213#comment-16501213
]
Jordan West commented on CASSANDRA-14451:
-----------------------------------------
[~jasobrown] change LGTM. A few questions and minor comments:
* Are the ArchiveCommitLog dtest failures expected on the 3.0 branch?
* The “sleep any time we have left” comment would be more appropriate above
the assignment of {{wakeUpAt}}.
* Mark {{maybeLogFlushLag}} and {{getTotalSyncDuration}} as
{{@VisibleForTesting}}
* Just wanted to check that the change in behavior of updating
{{totalSyncDuration}} is intentional. It makes sense to me that we only
increment it if a sync actually occurs but that wasn’t the case before.
* Is there are reason you opted for the “excessTimeToFlush” approach in 3.0
but the “maxFlushTimestamp” approach on 3.11 and trunk? The only difference I
see is the unit of time.
> Infinity ms Commit Log Sync
> ---------------------------
>
> Key: CASSANDRA-14451
> URL: https://issues.apache.org/jira/browse/CASSANDRA-14451
> Project: Cassandra
> Issue Type: Bug
> Environment: 3.11.2 - 2 DC
> Reporter: Harry Hough
> Assignee: Jason Brown
> Priority: Minor
> Fix For: 3.0.x, 3.11.x, 4.0.x
>
>
> Its giving commit log sync warnings where there were apparently zero syncs
> and therefore gives "Infinityms" as the average duration
> {code:java}
> WARN [PERIODIC-COMMIT-LOG-SYNCER] 2018-05-16 21:11:14,294
> NoSpamLogger.java:94 - Out of 0 commit log syncs over the past 0.00s with
> average duration of Infinityms, 1 have exceeded the configured commit
> interval by an average of 74.40ms
> WARN [PERIODIC-COMMIT-LOG-SYNCER] 2018-05-16 21:16:57,844
> NoSpamLogger.java:94 - Out of 0 commit log syncs over the past 0.00s with
> average duration of Infinityms, 1 have exceeded the configured commit
> interval by an average of 198.69ms
> WARN [PERIODIC-COMMIT-LOG-SYNCER] 2018-05-16 21:24:46,325
> NoSpamLogger.java:94 - Out of 0 commit log syncs over the past 0.00s with
> average duration of Infinityms, 1 have exceeded the configured commit
> interval by an average of 264.11ms
> WARN [PERIODIC-COMMIT-LOG-SYNCER] 2018-05-16 21:29:46,393
> NoSpamLogger.java:94 - Out of 32 commit log syncs over the past 268.84s with,
> average duration of 17.56ms, 1 have exceeded the configured commit interval
> by an average of 173.66ms{code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
