[ https://issues.apache.org/jira/browse/CASSANDRA-14451?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16501923#comment-16501923 ]
Jordan West commented on CASSANDRA-14451: ----------------------------------------- {quote} I left it where it was previously located, but can move it to the more logical spot. {quote} I don't find it very useful where it is now. Would vote to move it or remove it (the code is pretty clear). {quote}I wanted to keep the logic as close to the original as possible, since 3.0 is far along in it's age. I suppose it doesn't matter that much, though, and can change if you think it's worthwhile. wdyt? {quote} >From the review perspective it was just a second implementation to check for >correctness and it seems like either implementation could be used. Would vote >for them to be the same but fine as is if you prefer. Otherwise, +1 > Infinity ms Commit Log Sync > --------------------------- > > Key: CASSANDRA-14451 > URL: https://issues.apache.org/jira/browse/CASSANDRA-14451 > Project: Cassandra > Issue Type: Bug > Environment: 3.11.2 - 2 DC > Reporter: Harry Hough > Assignee: Jason Brown > Priority: Minor > Fix For: 3.0.x, 3.11.x, 4.0.x > > > Its giving commit log sync warnings where there were apparently zero syncs > and therefore gives "Infinityms" as the average duration > {code:java} > WARN [PERIODIC-COMMIT-LOG-SYNCER] 2018-05-16 21:11:14,294 > NoSpamLogger.java:94 - Out of 0 commit log syncs over the past 0.00s with > average duration of Infinityms, 1 have exceeded the configured commit > interval by an average of 74.40ms > WARN [PERIODIC-COMMIT-LOG-SYNCER] 2018-05-16 21:16:57,844 > NoSpamLogger.java:94 - Out of 0 commit log syncs over the past 0.00s with > average duration of Infinityms, 1 have exceeded the configured commit > interval by an average of 198.69ms > WARN [PERIODIC-COMMIT-LOG-SYNCER] 2018-05-16 21:24:46,325 > NoSpamLogger.java:94 - Out of 0 commit log syncs over the past 0.00s with > average duration of Infinityms, 1 have exceeded the configured commit > interval by an average of 264.11ms > WARN [PERIODIC-COMMIT-LOG-SYNCER] 2018-05-16 21:29:46,393 > NoSpamLogger.java:94 - Out of 32 commit log syncs over the past 268.84s with, > average duration of 17.56ms, 1 have exceeded the configured commit interval > by an average of 173.66ms{code} -- This message was sent by Atlassian JIRA (v7.6.3#76005) --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org