[
https://issues.apache.org/jira/browse/CASSANDRA-14772?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16626226#comment-16626226
]
Dinesh Joshi commented on CASSANDRA-14772:
------------------------------------------
{quote}What I will say here: refactoring code almost always introduces new
defects while fixing old ones; this is a lesson we should all know all too well
on this project.
{quote}
By that logic, we should not change any code ;) Exercising caution and good
judgment in refactors is important. I think all the bullets that [~krummas]
listed seem to be reasonable. See specifics below.
{quote}Fix performance regression in FQL that makes it less usable than it
should be.
{quote}
Bug
{quote}move full query log specific code to a separate package
{quote}
Low risk change
{quote}do some audit log class renames (I keep reading {{BinLogAuditLogger}} vs
{{BinAuditLogger}} wrong for example)
{quote}
Low risk change
{quote}avoid parsing the CQL queries twice in {{QueryMessage}} when audit log
is enabled.
{quote}
Bug
{quote}add a new tool to dump audit logs (ie, let fqltool be full query log
specific). fqltool crashes when pointed to them.
{quote}
This is avoiding changes to a public API (I consider tools as Public API) in
the next release. From a user's standpoint it's a good thing to have.
> Fix issues in audit / full query log interactions
> -------------------------------------------------
>
> Key: CASSANDRA-14772
> URL: https://issues.apache.org/jira/browse/CASSANDRA-14772
> Project: Cassandra
> Issue Type: Bug
> Reporter: Marcus Eriksson
> Assignee: Marcus Eriksson
> Priority: Major
> Fix For: 4.0
>
>
> There are some problems with the audit + full query log code that need to be
> resolved before 4.0 is released:
> * Fix performance regression in FQL that makes it less usable than it should
> be.
> * move full query log specific code to a separate package
> * do some audit log class renames (I keep reading {{BinLogAuditLogger}} vs
> {{BinAuditLogger}} wrong for example)
> * avoid parsing the CQL queries twice in {{QueryMessage}} when audit log is
> enabled.
> * add a new tool to dump audit logs (ie, let fqltool be full query log
> specific). fqltool crashes when pointed to them.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
