[ https://issues.apache.org/jira/browse/CASSANDRA-14772?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16626309#comment-16626309 ]
Jordan West commented on CASSANDRA-14772: ----------------------------------------- [~JoshuaMcKenzie] I appreciate you ensuring we keep to the freeze. I agree that once we start sneaking things past we open pandora’s box and make the freeze much less valuable. My understanding is that we agreed to address exceptions on a case-by-case basis, which we seem to be doing. We don’t have a formal process for doing so but a good litmus test imo is will the change improve the stability (where stability means performance and correctness) of Cassandra 4.0 and at what cost/risk does that improvement come with. I had more written on using that test here but I think folks have already summarized how this change improves stability with low risk — in particular if the refactors are fully automated by a tested tool like IntelliJ. > Fix issues in audit / full query log interactions > ------------------------------------------------- > > Key: CASSANDRA-14772 > URL: https://issues.apache.org/jira/browse/CASSANDRA-14772 > Project: Cassandra > Issue Type: Bug > Reporter: Marcus Eriksson > Assignee: Marcus Eriksson > Priority: Major > Fix For: 4.0 > > > There are some problems with the audit + full query log code that need to be > resolved before 4.0 is released: > * Fix performance regression in FQL that makes it less usable than it should > be. > * move full query log specific code to a separate package > * do some audit log class renames (I keep reading {{BinLogAuditLogger}} vs > {{BinAuditLogger}} wrong for example) > * avoid parsing the CQL queries twice in {{QueryMessage}} when audit log is > enabled. > * add a new tool to dump audit logs (ie, let fqltool be full query log > specific). fqltool crashes when pointed to them. -- This message was sent by Atlassian JIRA (v7.6.3#76005) --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org