[
https://issues.apache.org/jira/browse/CASSANDRA-14815?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16708628#comment-16708628
]
Benedict edited comment on CASSANDRA-14815 at 12/4/18 12:23 PM:
----------------------------------------------------------------
Yes, these changes are good. +1.
But: we should update the comments in {{terminateWorkers}}, and we should add a
comment to {{STOP_SIGNALLED}} that it may ONLY be assigned in {{maybeStop}} as
we now depend on this for correctness of termination of the threads. We should
perhaps also put a comment under {{doWaitSpin}} that we *must* continue here to
re-check {{isShuttingDown}}. Neither of these are strict requirements of the
design, so whilst they shouldn't change, we should document the dependencies.
was (Author: benedict):
Yes, these changes are good. +1.
But: we should update the comments in {{terminateWorkers}}, and we should add a
comment to {{STOP_SIGNALLED}} that it may ONLY be assigned in {{maybeStop}} as
we now depend on this for correctness of termination of the threads. This
shouldn't change, but we should document the dependency.
> SEPExecutor does not fully shut down
> ------------------------------------
>
> Key: CASSANDRA-14815
> URL: https://issues.apache.org/jira/browse/CASSANDRA-14815
> Project: Cassandra
> Issue Type: Bug
> Components: Lifecycle
> Reporter: Alex Petrov
> Assignee: Alex Petrov
> Priority: Minor
>
> When trying to shut down an SEP Executor, a parked worked will still be
> parked on:
> {code}
> sun.misc.Unsafe.park(Native Method)
> java.util.concurrent.locks.LockSupport.park(LockSupport.java:304)
> org.apache.cassandra.concurrent.SEPWorker.run(SEPWorker.java:88)
> io.netty.util.concurrent.FastThreadLocalRunnable.run(FastThreadLocalRunnable.java:30)
> java.lang.Thread.run(Thread.java:748)
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
