[
https://issues.apache.org/jira/browse/CASSANDRA-14815?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16709023#comment-16709023
]
Benedict edited comment on CASSANDRA-14815 at 12/4/18 5:40 PM:
---------------------------------------------------------------
[here|https://github.com/ifesdjeen/cassandra/blob/cd7235d004d5ec99cb937fe213dd99b044782083/src/java/org/apache/cassandra/concurrent/SharedExecutorPool.java#L134]
I meant for "enter the SPINNING state," to become something like "are
runnable", because we no longer require they enter the SPINNING state to check
the condition (although we do enter the spinning state, it is no longer a
requirement).
[here|https://github.com/ifesdjeen/cassandra/commit/cd7235d004d5ec99cb937fe213dd99b044782083#diff-d9febddfa9880b152f1b86242708b862R83]
something slightly more descriptive about why would be useful, such as "if the
pool is terminating, but we have been assigned STOP_SIGNALLED, if we do not
continue to re-check pool.shuttingDown this thread will block forever"
Otherwise, +1 LGTM
was (Author: benedict):
[here|https://github.com/ifesdjeen/cassandra/blob/cd7235d004d5ec99cb937fe213dd99b044782083/src/java/org/apache/cassandra/concurrent/SharedExecutorPool.java#L134]
I meant for "enter the SPINNING state," to become something like "are
runnable", because we no longer require they enter the SPINNING state to check
the condition (although we do enter the spinning state, it is no longer a
requirement).
[here|https://github.com/ifesdjeen/cassandra/commit/cd7235d004d5ec99cb937fe213dd99b044782083#diff-d9febddfa9880b152f1b86242708b862R83]
something slightly more descriptive about why would be useful, such as "if the
pool is terminating, but we have been assigned STOP_SIGNALLED, if we do not
continue to re-check pool.shuttingDown this thread will block forever"
> SEPExecutor does not fully shut down
> ------------------------------------
>
> Key: CASSANDRA-14815
> URL: https://issues.apache.org/jira/browse/CASSANDRA-14815
> Project: Cassandra
> Issue Type: Bug
> Components: Lifecycle
> Reporter: Alex Petrov
> Assignee: Alex Petrov
> Priority: Minor
>
> When trying to shut down an SEP Executor, a parked worked will still be
> parked on:
> {code}
> sun.misc.Unsafe.park(Native Method)
> java.util.concurrent.locks.LockSupport.park(LockSupport.java:304)
> org.apache.cassandra.concurrent.SEPWorker.run(SEPWorker.java:88)
> io.netty.util.concurrent.FastThreadLocalRunnable.run(FastThreadLocalRunnable.java:30)
> java.lang.Thread.run(Thread.java:748)
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
