[
https://issues.apache.org/jira/browse/CASSANDRA-14931?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16746243#comment-16746243
]
Alex Petrov commented on CASSANDRA-14931:
-----------------------------------------
Thank you for the patch!
Since this was largely reviewed and these are just backports, it was relatively
simple to review those.
+1 with several minor things:
* 2.2 branch tests are failing with the same exception wrapping failure we've
discussed in [CASSANDRA-14922] followup.
* Older branches are slightly different from trunk in terms of MBean
registration: in 4.0 {{PermissionsCache}} and {{RolesCache}} inherit from
{{AuthCache}}; so we need to use {{MBeanWrapper}} in these two classes in older
version. We do not have tests that use those just yet so we didn't have
automated means to detect it, but it's also simple enough to fix.
* You remove
[static|https://github.com/belliottsmith/cassandra/commit/4748a6d61b9715de87cd5cc20acc9f09391b4348#diff-d4e3b82e9bebfd2cb466b4a30af07fa4L118]
modified here but it is present in 4.0. I'm ok either way, just making sure it
was intentional (and probably it makes sense to make it uniform).
* On 3.11 it looks like logging initialisation has changed / is different
from the rest of branches. (I assume) Per classloader we get the following:
{code}
SLF4J: The following set of substitute loggers may have been accessed
SLF4J: during the initialization phase. Logging calls during this
SLF4J: phase were not honored. However, subsequent logging calls to these
SLF4J: loggers will work as normally expected.
SLF4J: See also http://www.slf4j.org/codes.html#substituteLogger
{code}
> Backport In-JVM dtests to 2.2, 3.0 and 3.11
> -------------------------------------------
>
> Key: CASSANDRA-14931
> URL: https://issues.apache.org/jira/browse/CASSANDRA-14931
> Project: Cassandra
> Issue Type: Improvement
> Components: Test/dtest
> Reporter: Benedict
> Assignee: Benedict
> Priority: Major
> Fix For: 2.2.14, 3.0.18, 3.11.4
>
>
> The In-JVM dtests are of significant value, and much of the testing we are
> exploring with it can easily be utilised on all presently maintained
> versions. We should backport the functionality to at least 3.0.x and 3.11.x
> - and perhaps even consider 2.2.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
