[
https://issues.apache.org/jira/browse/CASSANDRA-15225?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16901269#comment-16901269
]
Benedict commented on CASSANDRA-15225:
--------------------------------------
Thanks for the patch [~Override].
There's a third option, namely accumulating the throwable in a {{Throwable}}
variable, and maintaining the single catch clause. We have a utility method,
{{Throwables.maybeFail}} that takes a checked exception class, and rethrows the
exception as its checked-type if possible, or as an unchecked type if possible,
and otherwise wraps it in a {{RuntimeException}}.
Does that sound reasonable to you?
> FileUtils.close() does not handle non-IOException
> -------------------------------------------------
>
> Key: CASSANDRA-15225
> URL: https://issues.apache.org/jira/browse/CASSANDRA-15225
> Project: Cassandra
> Issue Type: Bug
> Components: Local/SSTable
> Reporter: Benedict
> Assignee: Liudmila Kornilova
> Priority: Normal
> Labels: pull-request-available
> Fix For: 3.0.x, 3.11.x, 4.0.x
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> This can lead to {{close}} not being invoked on remaining items
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
