[ https://issues.apache.org/jira/browse/CASSANDRA-15225?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16901969#comment-16901969 ]
Benedict commented on CASSANDRA-15225: -------------------------------------- Thanks [~Override]. One tiny nit: {{maybeFail}} doesn't require the null check, you can simply invoke it, and if the parameter is {{null}} nothing will happen. If you want to prepare the final patch for commit, by squashing, adding a CHANGES.txt entry, and adding a commit message of the form described on CASSANDRA-15246, I'll commit it to trunk. Welcome to the contributor community! > FileUtils.close() does not handle non-IOException > ------------------------------------------------- > > Key: CASSANDRA-15225 > URL: https://issues.apache.org/jira/browse/CASSANDRA-15225 > Project: Cassandra > Issue Type: Bug > Components: Local/SSTable > Reporter: Benedict > Assignee: Liudmila Kornilova > Priority: Normal > Labels: pull-request-available > Fix For: 3.0.x, 3.11.x, 4.0.x > > Time Spent: 10m > Remaining Estimate: 0h > > This can lead to {{close}} not being invoked on remaining items -- This message was sent by Atlassian JIRA (v7.6.14#76016) --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org