[ 
https://issues.apache.org/jira/browse/CASSANDRA-15582?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17056254#comment-17056254
 ] 

David Capwell commented on CASSANDRA-15582:
-------------------------------------------

In short diff metric names?  Not ambitious enough for me ;)


I’m finding that 3.x disk metrics are inaccurate (Marcus is looking at parts, 
when I get time I’ll fix other issues), Jordan pointed out the need to verify a 
performance changes impact on metric quality; for me there are a few things

1) diff metrics names (did we remove something? Change name is a remove)
2) diff metric signature (Used to return long but now string, used to take no 
arguments but now takes string, etc)
3) metric value accuracy

#1 and #2 are a api compatibility test where as #3 is a metrics quality test. 
For #3 I care less about new metrics than metrics people use in prod (new 
metrics should be tested as well but don’t break users if wrong), so #3 may 
need feedback on what metrics people monitor 

> 4.0 quality testing: metrics
> ----------------------------
>
>                 Key: CASSANDRA-15582
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-15582
>             Project: Cassandra
>          Issue Type: Task
>          Components: Test/dtest
>            Reporter: Josh McKenzie
>            Assignee: Romain Hardouin
>            Priority: Normal
>             Fix For: 4.0-rc
>
>
> In past releases we've unknowingly broken metrics integrations and introduced 
> performance regressions in metrics collection and reporting. We strive in 4.0 
> to not do that. Metrics should work well!



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org

Reply via email to