[ 
https://issues.apache.org/jira/browse/CASSANDRA-15773?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17101123#comment-17101123
 ] 

Dinesh Joshi commented on CASSANDRA-15773:
------------------------------------------

[~spmallette] I think the test is ok. I don't think you're not leaking memory 
([~dcapwell] please correct me if I am missing something here). A few things to 
think about -

# You're making gets of the same size. I feel randomizing the size of requested 
buffers would be better
# We should add negative test cases i.e. request buffers with bad sizes

> Add test to cover metrics related to the BufferPool
> ---------------------------------------------------
>
>                 Key: CASSANDRA-15773
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-15773
>             Project: Cassandra
>          Issue Type: Improvement
>          Components: Test/unit
>            Reporter: Stephen Mallette
>            Assignee: Stephen Mallette
>            Priority: Normal
>
> At this time there do not appear to be unit tests to validate 
> {{BufferPoolMetrics}}.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org

Reply via email to