[
https://issues.apache.org/jira/browse/CASSANDRA-15773?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17101888#comment-17101888
]
David Capwell commented on CASSANDRA-15773:
-------------------------------------------
bq. I've initialized the test with a fixed size to the pool
Sorry, must have missed that.
bq. I might not understand something but I thought that this would prevent such
problems:
I most likely didn't look close enough, feel free to ignore me with regard to
leaking.
Thanks for the new failure tests!
*
https://github.com/apache/cassandra/compare/trunk...spmallette:CASSANDRA-15773-trunk#diff-790a43fcd6ed69f4122cd0fe205c847bR187-R198.
You could use
org.assertj.core.api.Assertions#assertThatThrownBy(org.assertj.core.api.ThrowableAssert.ThrowingCallable).
Other than that, this patch LGTM so I am +1. Ill run it through CI to make
sure its stable
> Add test to cover metrics related to the BufferPool
> ---------------------------------------------------
>
> Key: CASSANDRA-15773
> URL: https://issues.apache.org/jira/browse/CASSANDRA-15773
> Project: Cassandra
> Issue Type: Improvement
> Components: Test/unit
> Reporter: Stephen Mallette
> Assignee: Stephen Mallette
> Priority: Normal
>
> At this time there do not appear to be unit tests to validate
> {{BufferPoolMetrics}}.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
