[ 
https://issues.apache.org/jira/browse/CASSANDRA-15877?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17140064#comment-17140064
 ] 

Ekaterina Dimitrova commented on CASSANDRA-15877:
-------------------------------------------------

[ [branch 
|https://github.com/ekaterinadimitrova2/cassandra/tree/CASSANDRA-15600-followup]]
 [ [Java8 CI 
|https://app.circleci.com/pipelines/github/ekaterinadimitrova2/cassandra/222/workflows/46515d14-9be4-4edb-8db4-5930312d2bfb]]
 [ [Java11 CI 
|https://app.circleci.com/pipelines/github/ekaterinadimitrova2/cassandra/222/workflows/11202c7e-6c94-4d4e-bbbf-9e2fa9791ad0]]
 [ [pull request |https://github.com/ekaterinadimitrova2/cassandra/pull/44]]

Failing dtests not related to this patch but I didn't find tickets so probably 
good to follow up on them:

JAVA 11:

test_resumable_rebuild - rebuild_test.TestRebuild - not related but I didn't 
find a ticket so good to follow up on it probably

test_short_read - consistency_test.TestConsistency - not related but I didn't 
find a ticket so good to follow up on it probably

JAVA 8:

test_multiple_repair - repair_tests.incremental_repair_test.TestIncRepair - not 
related but I didn't find a ticket so good to follow up on it probably

The rest of the dtests failures are handled under 
[CASSANDRA-15677|https://issues.apache.org/jira/browse/CASSANDRA-15677] 

Screenshot added to prove the fixed unit test is not flaky anymore. 

*The first commit is the actual patch. The second commit applies our custom 
CircleCI config and shouldn't be committed! Kept for test purposes.*

*The third commit is to add event for new split generations plus removal of 
unused code.*

 

> Followup on CASSANDRA-15600
> ---------------------------
>
>                 Key: CASSANDRA-15877
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-15877
>             Project: Cassandra
>          Issue Type: Bug
>          Components: Feature/Virtual Nodes
>            Reporter: Ekaterina Dimitrova
>            Assignee: Ekaterina Dimitrova
>            Priority: Normal
>             Fix For: 4.0, 4.0-alpha
>
>         Attachments: Screen Shot 2020-06-12 at 3.21.18 PM.png
>
>
> As part of CASSANDRA-15600  generateSplits method replaced the 
> generateRandomTokens for NoReplicationAwareTokenAllocator.  generateSplits 
> should be used also in ReplicationAwareTokenAllocator.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org

Reply via email to