[
https://issues.apache.org/jira/browse/CASSANDRA-15877?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17140392#comment-17140392
]
Berenguer Blasi commented on CASSANDRA-15877:
---------------------------------------------
[~e.dimitrova] I had some cycles so wanted to help with the review here. The
tests you point out are pretty stable on ci-cassandra see
[here|https://ci-cassandra.apache.org/job/Cassandra-trunk/176/testReport/dtest-novnode.repair_tests.incremental_repair_test/TestIncRepair/test_multiple_repair/history/],
[here|https://ci-cassandra.apache.org/job/Cassandra-trunk/176/testReport/dtest.rebuild_test/TestRebuild/test_resumable_rebuild/history/]
and
[here|https://ci-cassandra.apache.org/job/Cassandra-trunk/176/testReport/dtest-novnode.consistency_test/TestConsistency/test_short_read/history/].
So I would suggest you run those locally just to make sure. Otherwise lgtm +1
> Followup on CASSANDRA-15600
> ---------------------------
>
> Key: CASSANDRA-15877
> URL: https://issues.apache.org/jira/browse/CASSANDRA-15877
> Project: Cassandra
> Issue Type: Bug
> Components: Feature/Virtual Nodes
> Reporter: Ekaterina Dimitrova
> Assignee: Ekaterina Dimitrova
> Priority: Normal
> Fix For: 4.0, 4.0-alpha
>
> Attachments: Screen Shot 2020-06-12 at 3.21.18 PM.png
>
>
> As part of CASSANDRA-15600 generateSplits method replaced the
> generateRandomTokens for NoReplicationAwareTokenAllocator. generateSplits
> should be used also in ReplicationAwareTokenAllocator.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
