[
https://issues.apache.org/jira/browse/CASSANDRA-15234?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17151255#comment-17151255
]
Michael Semb Wever edited comment on CASSANDRA-15234 at 7/4/20, 9:21 AM:
-------------------------------------------------------------------------
bq. I don't think this is an absolute necessity for pre-beta, however, given
that we have agreed for it to be backwards compatible. I don't see any issue
with landing this in a later beta.
Move it out to a separate ticket, like was done for CASSANDRA-15876. To bring
additional spec to the table, no matter how good it is, so late in the ticket
and so close to the first beta, is particularly painful. As a separate ticket
it can be done during the beta phase.
Otherwise the settings now have a consistent naming pattern {{<noun>_<verb>}}
which, with no unit suffix noise, and better grouping the settings in the yaml,
already brings a huge improvement.
was (Author: michaelsembwever):
bq. I don't think this is an absolute necessity for pre-beta, however, given
that we have agreed for it to be backwards compatible. I don't see any issue
with landing this in a later beta.
Move it out to a separate ticket, like was done for CASSANDRA-15876. To bring
additional spec to the table, no matter how good it is, so late in the ticket
and so close to the first beta, is particularly painful. As a separate ticket
it can be done during the beta phase.
Otherwise the settings now have a consistent naming pattern {{<noun>_<verb>}}
which, no unit suffix noise, and better grouping the settings in the yaml,
already brings a huge improvement.
> Standardise config and JVM parameters
> -------------------------------------
>
> Key: CASSANDRA-15234
> URL: https://issues.apache.org/jira/browse/CASSANDRA-15234
> Project: Cassandra
> Issue Type: Bug
> Components: Local/Config
> Reporter: Benedict Elliott Smith
> Assignee: Ekaterina Dimitrova
> Priority: Normal
> Fix For: 4.0-alpha
>
> Attachments: CASSANDRA-15234-3-DTests-JAVA8.txt
>
>
> We have a bunch of inconsistent names and config patterns in the codebase,
> both from the yams and JVM properties. It would be nice to standardise the
> naming (such as otc_ vs internode_) as well as the provision of values with
> units - while maintaining perpetual backwards compatibility with the old
> parameter names, of course.
> For temporal units, I would propose parsing strings with suffixes of:
> {{code}}
> u|micros(econds?)?
> ms|millis(econds?)?
> s(econds?)?
> m(inutes?)?
> h(ours?)?
> d(ays?)?
> mo(nths?)?
> {{code}}
> For rate units, I would propose parsing any of the standard {{B/s, KiB/s,
> MiB/s, GiB/s, TiB/s}}.
> Perhaps for avoiding ambiguity we could not accept bauds {{bs, Mbps}} or
> powers of 1000 such as {{KB/s}}, given these are regularly used for either
> their old or new definition e.g. {{KiB/s}}, or we could support them and
> simply log the value in bytes/s.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
