[ https://issues.apache.org/jira/browse/CASSANDRA-15583?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17164314#comment-17164314 ]
Berenguer Blasi commented on CASSANDRA-15583: --------------------------------------------- [~samt] I made some progress, see description for a cursory qualitative finger in the air evaluation of current tooling coverage. Nodetool, Cqlsh, cassandra-stress and debug-cql look like a small project each probably deserving dedicated tickets. Going into each of the rest of the other tools and working out how to improve actual unit testing coverage per tool it's a good LHF ticket for beginners imo. So I propose the following: A. Add UX UT to all sstable utils + fqltool + auditlogviewer. Also convert dtests for the above tools into UT where possible/sensible. These 2 should 'seed' testing for those tools in the right direction. Any later improvements will naturally build upon that testing. UT as default and dtests only when you need a fully working multi-node cluster. B. Create tickets for each of the big ones: Nodetool, Cqlsh, cassandra-stress and debug-cql to be done outside of this ticket C. Create smaller LHF tickets to improve UT coverage of each of the tools to be done outside of this ticket I think this is a sensible balance between the mammoth 'fix all the things and never be done' and adding new tests & seeding things in the right direction. It gives 'resolution' to scope things in/out having smaller self-contained tickets which is nice, it creates LHF tickets for anybody new wanting to contribute/ramp-up i.e., also as a dev I'd prefer that than a long-running 50K loc line PR, etc But that's just me feel free to correct me :) Changing gears: If we got the review of what we have already done and merged I can think of CASSANDRA-15971 and CASSANDRA-15896 benefiting from that #justfyi #collaborating wdyt any of the above makes sense? Legend: UX UT = test params, mandatory, non mandatory, return codes, output if any etc > 4.0 quality testing: Tooling, Bundled and First Party > ----------------------------------------------------- > > Key: CASSANDRA-15583 > URL: https://issues.apache.org/jira/browse/CASSANDRA-15583 > Project: Cassandra > Issue Type: Task > Components: Test/dtest, Test/unit > Reporter: Josh McKenzie > Assignee: Berenguer Blasi > Priority: Normal > Fix For: 4.0-beta > > > Reference [doc from > NGCC|https://docs.google.com/document/d/1uhUOp7wpE9ZXNDgxoCZHejHt5SO4Qw1dArZqqsJccyQ/edit#] > for context. > *Shepherd: Sam Tunnicliffe* > Test plans should cover bundled first-party tooling and CLIs such as > nodetool, cqlsh, and new tools supporting full query and audit logging > (CASSANDRA-13983, CASSANDRA-12151). > ||Tool||UX test||UT coverage||dtest coverage||Comments|| > |Nodetool|(x)|(x)|(!)|By no means all the sub commands are tested. Dtest also > test nodetool as a side effect| > |Cqlsh|(x)|(x)|(!)| | > |Cassandra-stress|(x)|(x)|(x)| Some UT| > |debug-cql|(x)|(x)|(x)| | > |fqltool|(x)|(/)|(!)| | > |auditlogviewer|(x)|(!)|(!)| | > |*Sstable utilities*| | | | | > |sstabledump|(x)|(x)|(!)| | > |sstableexpiredblockers|(x)|(x)|(!)| | > |sstablelevelreset|(x)|(x)|(!)| | > |sstableloader|(x)|(x)|(!)| | > |sstablemetadata|(x)|(x)|(x)|Ran in dtests, no dedicated test| > |sstableofflinerelevel|(x)|(x)|(!)| | > |sstablerepairedset|(x)|(x)|(x)|Ran in dtests, no dedicated test| > |sstablescrub|(x)|(x)|(!)| | > |sstablesplit|(x)|(x)|(!)| | > |sstableupgrade|(x)|(x)|(!)| | > |sstableutil|(x)|(x)|(!)| | > |sstableverify|(x)|(x)|(!)| | -- This message was sent by Atlassian Jira (v8.3.4#803005) --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org