[ https://issues.apache.org/jira/browse/CASSANDRA-15965?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17196569#comment-17196569 ]
Adam Holmberg commented on CASSANDRA-15965: ------------------------------------------- [This|https://github.com/apache/cassandra/blob/07f8db31ae10a3883c06194642354feb711e361c/test/unit/org/apache/cassandra/streaming/async/StreamingInboundHandlerTest.java#L98] "unsafe" assertion is racing with [this|https://github.com/apache/cassandra/blob/07f8db31ae10a3883c06194642354feb711e361c/src/java/org/apache/cassandra/streaming/async/StreamingInboundHandler.java#L164-L172] background read. My recommendation is to remove the test. It's testing so very little (we can queue a message), and so fundamental -- I believe we have quite a bit of coverage for this elsewhere. While looking at this I discovered a possible NPE in StreamMessage type lookups. The lookup table had a null value in the zero index. I'm including a potential fix for that. [Patch|https://github.com/apache/cassandra/compare/trunk...aholmberg:CASSANDRA-15965] [ci|https://app.circleci.com/pipelines/github/aholmberg/cassandra?branch=CASSANDRA-15965] > Fix flaky test StreamingInboundHandlerTest channelRead_Normal > ------------------------------------------------------------- > > Key: CASSANDRA-15965 > URL: https://issues.apache.org/jira/browse/CASSANDRA-15965 > Project: Cassandra > Issue Type: Bug > Components: Test/unit > Reporter: David Capwell > Priority: Normal > Fix For: 4.0-beta > > > channelRead_Normal - > org.apache.cassandra.streaming.async.StreamingInboundHandlerTest > {code} > junit.framework.AssertionFailedError: expected:<8> but was:<0> > at > org.apache.cassandra.streaming.async.StreamingInboundHandlerTest.channelRead_Normal(StreamingInboundHandlerTest.java:98) > {code} > Failed build: > https://app.circleci.com/pipelines/github/dcapwell/cassandra/298/workflows/e3296f33-2289-401c-8fc8-a7f786e3692a/jobs/1445 -- This message was sent by Atlassian Jira (v8.3.4#803005) --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org