[ https://issues.apache.org/jira/browse/CASSANDRA-15965?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17197165#comment-17197165 ]
Adam Holmberg commented on CASSANDRA-15965: ------------------------------------------- > Util#spinAssertEquals could be an alternative, and the test can be kept. It's not a matter of the test thread getting there too early -- it gets there too late and the condition will never be true. By then the buffer has been read. >Do we want to open a new ticket for fixing the NPE? In the past we've included production code changes in the flaky test ticket that discovered them. I will open a new ticket if that's needed. lmk. > Fix flaky test StreamingInboundHandlerTest channelRead_Normal > ------------------------------------------------------------- > > Key: CASSANDRA-15965 > URL: https://issues.apache.org/jira/browse/CASSANDRA-15965 > Project: Cassandra > Issue Type: Bug > Components: Test/unit > Reporter: David Capwell > Assignee: Adam Holmberg > Priority: Normal > Fix For: 4.0-beta > > > channelRead_Normal - > org.apache.cassandra.streaming.async.StreamingInboundHandlerTest > {code} > junit.framework.AssertionFailedError: expected:<8> but was:<0> > at > org.apache.cassandra.streaming.async.StreamingInboundHandlerTest.channelRead_Normal(StreamingInboundHandlerTest.java:98) > {code} > Failed build: > https://app.circleci.com/pipelines/github/dcapwell/cassandra/298/workflows/e3296f33-2289-401c-8fc8-a7f786e3692a/jobs/1445 -- This message was sent by Atlassian Jira (v8.3.4#803005) --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org