[
https://issues.apache.org/jira/browse/CASSANDRA-16057?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17198113#comment-17198113
]
Alex Petrov commented on CASSANDRA-16057:
-----------------------------------------
I think this is a great addition which will make testing nodetool easier, as
[~dcapwell] has mentioned. I had a conversation about making output of nodetool
strucutred with [~stefan.miklosovic]. Ultimately, formatted output is good, but
structured reporting would be even better if we ever have chance to tacle this.
Maybe it's a good point to continue the conversation and create a separate
issue for this?
Another general thing to point out here is that, while doing some basic asserts
is useful, we probably should avoid more sophisticated parsing of nodetool
output, and implement tests that require involved parsing in some other way.
For in-jvm dtest patch, should we add {{doesNotContain}}? I realize this can be
currently checked manually with {{!stdout().contains(...)}}, but since we have
an asserts helper, we can consider adding it.
One minor that I've noticed is the new {{AutoCloseable}} warnings. We can work
around these, for example, by using public final fields instead of a method
that returns {{AutoCloseable}}, since which makes it not look like a factory
method anymore. Maybe there's a better way to do this.
I have left several minor comments on the issue, +1 otherwise!
> Should update in-jvm dtest to expose stdout and stderr for nodetool
> -------------------------------------------------------------------
>
> Key: CASSANDRA-16057
> URL: https://issues.apache.org/jira/browse/CASSANDRA-16057
> Project: Cassandra
> Issue Type: Improvement
> Components: Test/dtest/java
> Reporter: David Capwell
> Assignee: Yifan Cai
> Priority: Normal
> Time Spent: 2h
> Remaining Estimate: 0h
>
> Many nodetool commands output to stdout or stderr so running nodetool using
> in-jvm dtest should expose that to tests.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
