[ 
https://issues.apache.org/jira/browse/CASSANDRA-16057?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17198461#comment-17198461
 ] 

David Capwell commented on CASSANDRA-16057:
-------------------------------------------

bq. Ultimately, formatted output is good, but structured reporting would be 
even better if we ever have chance to tacle this. Maybe it's a good point to 
continue the conversation and create a separate issue for this?

+1 to separate issue.  

bq. We are just exposing there stdout and stderr. Please keep in mind that I 
need to do this against an instance, meaning I need to be able to do it such 
way that it will be executed in the "scope" of that node because I can spin up 
more clusters and I need to have "stdout" per each "jvm / classloader".

Yep, this is part of the nodetool interface, which is scoped to the single 
instance.  The implementation also deals with this by updating all nodetool 
commands to update an interface rather than stdout and stderr directly; this 
avoids concurrent node tools clobbering the capture.

bq.  I would love to merge 15406 very soon because it was there literally for 
months and it was blocked by few other tickets so I am personally little 
impatient here 

I don't mind us moving forward with 15406 without this patch; I thought you 
wanted to hold off given your comment in there.

Because both touch the same classes, if 15406 goes first then this patch needs 
to update the pointer from stdout to the new interface, if we hold off 15406 
then that would need to change the pointer.

> Should update in-jvm dtest to expose stdout and stderr for nodetool
> -------------------------------------------------------------------
>
>                 Key: CASSANDRA-16057
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-16057
>             Project: Cassandra
>          Issue Type: Improvement
>          Components: Test/dtest/java
>            Reporter: David Capwell
>            Assignee: Yifan Cai
>            Priority: Normal
>          Time Spent: 2h 10m
>  Remaining Estimate: 0h
>
> Many nodetool commands output to stdout or stderr so running nodetool using 
> in-jvm dtest should expose that to tests.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org

Reply via email to