[
https://issues.apache.org/jira/browse/CASSANDRA-16148?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17205126#comment-17205126
]
David Capwell commented on CASSANDRA-16148:
-------------------------------------------
bq. Can you say more about what you mean by "avoid caching when the version
isn't known".
Guava memoize doesn't support it so would require a custom implementation but
could indicate not to cache via a special exception that returns a value or
have the return type be a ADT that has Success, and NoCache.
bq. Otherwise, I think we need to opt for correctness over performance here.
I agree correctness is important here, but just concerned about mixed mode with
larger clusters. It would be great if we could get a baseline with and without
memoize with a 50-100 node cluster with at least 1 node in 3.x.
Also, my thinking was mostly that we could always fork the guava class, it is
15 lines of code (depending on implementation of NoCache, would be around 20~.
> Test failures caused by merging CASSANDRA-15833
> -----------------------------------------------
>
> Key: CASSANDRA-16148
> URL: https://issues.apache.org/jira/browse/CASSANDRA-16148
> Project: Cassandra
> Issue Type: Bug
> Components: Cluster/Gossip
> Reporter: Jordan West
> Assignee: Jordan West
> Priority: Normal
>
> Three issues were caused by merging CASSANDRA-15833:
> 1. `GossiperTest#testHaveAnyVersion3Nodes` was failing on trunk:
> https://app.circleci.com/pipelines/github/jrwest/cassandra/53/workflows/95f9f401-1ef8-4b8d-9c64-3703d9669d95/jobs/771
> 2. python dtest ReadRepairTest#test_atomic_writes[blocking] was failing
> 3. In-jvm dtests being worked on as part of CASSANDRA-15977 uncovered an
> issue with how CASSANDRA-15833 changes interacted with in-jvm dtests running
> without {{Feature.GOSSIP}}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
