[ 
https://issues.apache.org/jira/browse/CASSANDRA-14477?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17223042#comment-17223042
 ] 

Stefan Miklosovic edited comment on CASSANDRA-14477 at 10/29/20, 5:02 PM:
--------------------------------------------------------------------------

3.0

[https://github.com/apache/cassandra/pull/795]

3.11

[https://github.com/apache/cassandra/pull/796]

trunk

[https://github.com/apache/cassandra/pull/797]

 

for 3.0, I am not sure what is wrong with tests but they pass individually but 
fail when whole class is tested in bulk (in IDEA). I was not able to find out 
why it happens.


was (Author: stefan.miklosovic):
3.0

[https://github.com/apache/cassandra/pull/795]

3.11

[https://github.com/apache/cassandra/pull/796]

trunk

[https://github.com/apache/cassandra/pull/797]

 

for 3.0, I am not sure what is wrong with tests but they pass individually but 
fail when whole class is tested in bulk. I was not able to find out why it 
happens.

> The check of num_tokens against the length of inital_token in the yaml 
> triggers unexpectedly
> --------------------------------------------------------------------------------------------
>
>                 Key: CASSANDRA-14477
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-14477
>             Project: Cassandra
>          Issue Type: Bug
>          Components: Local/Config
>            Reporter: Vincent White
>            Assignee: Stefan Miklosovic
>            Priority: Low
>          Time Spent: 0.5h
>  Remaining Estimate: 0h
>
> In CASSANDRA-10120 we added a check that compares num_tokens against the 
> number of tokens supplied in the yaml via initial_token. From my reading of 
> CASSANDRA-10120 it was to prevent cassandra starting if the yaml contained 
> contradictory values for num_tokens and initial_tokens which should help 
> prevent misconfiguration via human error. The current behaviour appears to 
> differ slightly in that it performs this comparison regardless of whether 
> num_tokens is included in the yaml or not. Below are proposed patches to only 
> perform the check if both options are present in the yaml.
> ||Branch||
> |[3.0.x|https://github.com/apache/cassandra/compare/cassandra-3.0...vincewhite:num_tokens_30]|
> |[3.x|https://github.com/apache/cassandra/compare/cassandra-3.11...vincewhite:num_tokens_test_1_311]|



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org

Reply via email to