[ https://issues.apache.org/jira/browse/CASSANDRA-14477?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17234080#comment-17234080 ]
Michael Semb Wever edited comment on CASSANDRA-14477 at 11/18/20, 6:49 AM: --------------------------------------------------------------------------- This broke all the {{dtest-novnode}} dtests :( I suspect… - the check for num_tokens being defined should be skipped if initial_tokens defines only one token, as it unlikely to be a typo, folk would rarely be configuring two tokens, and just one initial_token is the traditional non-vnodes configuration predating the use of num_tokens - dtests define {{num_tokens=1}} for non-nvodes, [here|https://github.com/apache/cassandra-dtest/blob/d61eff9b89a2f4bbe1791e1cd71a5e3456d6cc94/dtest_setup.py#L426], - the [Cassandra-devbranch|https://ci-cassandra.apache.org/view/patches/job/Cassandra-devbranch/] jenkins pipeline should be including {{dtest-novnode}} was (Author: michaelsembwever): This broke all the {{dtest-novnode}} dtests :( I suspect… - the check for num_tokens being defined should be skipped if initial_tokens defines only one token (as it unlikely to be a typo, folk would rarely be configuring two tokens), - dtests define {{num_tokens=1}} for non-nvodes, [here|https://github.com/apache/cassandra-dtest/blob/d61eff9b89a2f4bbe1791e1cd71a5e3456d6cc94/dtest_setup.py#L426], - the [Cassandra-devbranch|https://ci-cassandra.apache.org/view/patches/job/Cassandra-devbranch/] jenkins pipeline should be including {{dtest-novnode}} > The check of num_tokens against the length of inital_token in the yaml > triggers unexpectedly > -------------------------------------------------------------------------------------------- > > Key: CASSANDRA-14477 > URL: https://issues.apache.org/jira/browse/CASSANDRA-14477 > Project: Cassandra > Issue Type: Bug > Components: Local/Config > Reporter: Vincent White > Assignee: Stefan Miklosovic > Priority: Low > Fix For: 3.0.23, 3.11.9, 4.0-beta4 > > Time Spent: 40m > Remaining Estimate: 0h > > In CASSANDRA-10120 we added a check that compares num_tokens against the > number of tokens supplied in the yaml via initial_token. From my reading of > CASSANDRA-10120 it was to prevent cassandra starting if the yaml contained > contradictory values for num_tokens and initial_tokens which should help > prevent misconfiguration via human error. The current behaviour appears to > differ slightly in that it performs this comparison regardless of whether > num_tokens is included in the yaml or not. Below are proposed patches to only > perform the check if both options are present in the yaml. > ||Branch|| > |[3.0.x|https://github.com/apache/cassandra/compare/cassandra-3.0...vincewhite:num_tokens_30]| > |[3.x|https://github.com/apache/cassandra/compare/cassandra-3.11...vincewhite:num_tokens_test_1_311]| -- This message was sent by Atlassian Jira (v8.3.4#803005) --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org