[
https://issues.apache.org/jira/browse/CASSANDRA-16261?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17267435#comment-17267435
]
Ekaterina Dimitrova edited comment on CASSANDRA-16261 at 1/18/21, 5:45 PM:
---------------------------------------------------------------------------
I am off today but I checked the results from the CI runs that I pushed at the
end of the week after the latest rebase, here are the results, it looks like
this solved the previous issues we saw:
[3.0 CI |https://ci-cassandra.apache.org/job/Cassandra-devbranch/297/]. | [3.0
patch |https://github.com/ekaterinadimitrova2/cassandra/pull/81]
We don't have history for the cqlsh tests and I don't see those in the last
builds but when I ran CI without my patch they [failed
again|https://jenkins-cm4.apache.org/job/Cassandra-devbranch/305/#showFailuresLink]
so I don't think this patch is the reason. Also I saw some of cqlsh failures
in 3.11.
=================
[3.11 CI |https://ci-cassandra.apache.org/job/Cassandra-devbranch/300/]. |
[3.11 patch|https://github.com/ekaterinadimitrova2/cassandra/pull/83/commits]
The cqlsh errors appeared in the last builds; It seems there is some typo that
needs to be fixed. I will see to fix it/raise a ticket but the issues is not
related to this patch.
=================
[trunk CI |https://ci-cassandra.apache.org/job/Cassandra-devbranch/301/] |.
[trunk patch|https://github.com/ekaterinadimitrova2/cassandra/pull/84/commits]
No failures
was (Author: e.dimitrova):
I am off today but I checked the results from the CI runs that I pushed at the
end of the week after the latest rebase, here are the results, it looks like
this solved the previous issues we saw:
[3.0 CI |https://ci-cassandra.apache.org/job/Cassandra-devbranch/297/]. | [3.0
patch |https://github.com/ekaterinadimitrova2/cassandra/pull/81]
We don't have history for the cqlsh tests and I don't see those in the last
builds but when I ran CI without my patch they [failed
again|https://jenkins-cm4.apache.org/job/Cassandra-devbranch/305/#showFailuresLink]
so I don't think this patch is the reason. Also I saw some of cqlsh failures
in 3.11.
=================
[3.11 CI |https://ci-cassandra.apache.org/job/Cassandra-devbranch/300/]. |
[3.11 patch|https://github.com/ekaterinadimitrova2/cassandra/pull/83/commits]
The cqlsh errors appeared in the last builds; It seems there is some typo that
needs to be fixed. I will see to fix it/raise a ticket but it is not related to
this one
=================
[trunk CI |https://ci-cassandra.apache.org/job/Cassandra-devbranch/301/] |.
[trunk patch|https://github.com/ekaterinadimitrova2/cassandra/pull/84/commits]
No failures
> Prevent unbounded number of flushing tasks
> ------------------------------------------
>
> Key: CASSANDRA-16261
> URL: https://issues.apache.org/jira/browse/CASSANDRA-16261
> Project: Cassandra
> Issue Type: Bug
> Components: Legacy/Local Write-Read Paths
> Reporter: Ekaterina Dimitrova
> Assignee: Ekaterina Dimitrova
> Priority: Normal
> Fix For: 3.0.x, 3.11.x, 4.0-beta
>
>
> The cleaner thread is not prevented from queueing an unbounded number of
> flushing tasks for memtables that are almost empty.
> This patch adds a mechanism to track the number of pending flushing
> tasks in the memtable cleaner. Above the maximum number (2x the flushing
> threads by default), only memtables using at least MCT memory will be
> flushed, where MCT stands for Memory Cleanup Threshold.
> This patch also fixes a possible problem tracking the memory marked as
> "reclaiming" in the memtable allocators and pool. Writes that complete
> only after a memtable has been scheduled for flushing, did not report
> their memory as reclaiming. Normally this should be a small value of no
> consequence, but if the flushing tasks are blocked for a long period,
> and there is a sufficient number of writes, or these writes use
> a sufficiently large quantity of memory, this would cause the memtable
> cleaning algorithm to schedule repeated flushing tasks because the used
> memory is always > reclaiming memory + MCT.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
