[
https://issues.apache.org/jira/browse/CASSANDRA-16483?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17297380#comment-17297380
]
Andres de la Peña commented on CASSANDRA-16483:
-----------------------------------------------
{quote}My only comment is about ReadCommand.toCQLString() where it seems that
we do not quote the keyspace and table name if needed. I am just not sure if we
should fix it in this patch or later on. May be we should address it with all
the other problems you mentioned.
{quote}
Good catch, I missed that one. I think that for this ticket we can focus on
{{ColumnFilter}} and the test failures introduced by CASSANDRA-16415. Then we
could have other ticket for all the other {{toCQLString}} methods, adding a new
exhaustive junit test suite instead of relying on {{TestCQLSlowQuery}} dtests.
That test would make sure that the output of {{toCQLString}} is always
parseable and, when parsed, it produces an equivalent command. Not sure whether
we should block 4.0 for that ticket.
As for the CI results above, it seems that upgrade tests are not working on
CircleCI for reasons not related to the patch. On ci-cassandra some of the
above runs for upgrade tests have failed because they are upgrading from the
development branches without the patch, so here are new runs with [an upgrade
manifest|https://github.com/adelapena/cassandra-dtest/commits/16483-manifest]
using the patched branches:
[ci-cassandra
3.0|https://ci-cassandra.apache.org/view/all/job/Cassandra-devbranch-dtest-upgrade/107/]
[ci-cassandra
3.11|https://ci-cassandra.apache.org/view/all/job/Cassandra-devbranch-dtest-upgrade/108/]
[ci-cassandra
trunk|https://ci-cassandra.apache.org/view/all/job/Cassandra-devbranch-dtest-upgrade/109/]
> ColumnFilter::toString doesn't return a valid CQL fragment
> ----------------------------------------------------------
>
> Key: CASSANDRA-16483
> URL: https://issues.apache.org/jira/browse/CASSANDRA-16483
> Project: Cassandra
> Issue Type: Bug
> Components: Observability/Logging
> Reporter: Sam Tunnicliffe
> Assignee: Andres de la Peña
> Priority: Normal
> Fix For: 4.0-beta
>
> Time Spent: 50m
> Remaining Estimate: 0h
>
> This was changed in CASSANDRA-16415 to include indications about queried vs
> fetched reagular & static columns. However, the result is used by
> {{AbstractReadQuery::toCQLString}}, which causes it to produce an illegal
> query string.
> This breaks a couple of dtests because they're looking for CQL strings in
> logs, which are no longer found:
> *
> {{upgrade_tests/paging_test.py::TestPagingWithDeletions::test_failure_threshold_deletions}}
> * {{cql_test.py::TestCQLSlowQuery}} has a couple of failing tests,
> {{test_local_query/test_remote_query}}
> We should also check audit and fql logs (and any other place where
> {{toCQLString}} is used.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
