[
https://issues.apache.org/jira/browse/CASSANDRA-16483?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17298207#comment-17298207
]
Andres de la Peña commented on CASSANDRA-16483:
-----------------------------------------------
Makes sense to me. Here is an additional run of the patch for trunk rebased to
include the last fixes in the CircleCI config file:
* [CircleCI trunk
j8|https://app.circleci.com/pipelines/github/adelapena/cassandra/220/workflows/32bc2b90-68ed-45f0-a2cd-472e6c03a9c7]
* [CircleCI trunk
j11|https://app.circleci.com/pipelines/github/adelapena/cassandra/220/workflows/12e1eb8b-4653-440e-814f-c0eb8d9163ca]
[~blerer] I think if the CI results look good and you agree with leaving the
additional changes in {{toCQLString}} methods for that followup ticket we are
ready to commit, wdyt?
> ColumnFilter::toString doesn't return a valid CQL fragment
> ----------------------------------------------------------
>
> Key: CASSANDRA-16483
> URL: https://issues.apache.org/jira/browse/CASSANDRA-16483
> Project: Cassandra
> Issue Type: Bug
> Components: Observability/Logging
> Reporter: Sam Tunnicliffe
> Assignee: Andres de la Peña
> Priority: Normal
> Fix For: 4.0-beta
>
> Time Spent: 50m
> Remaining Estimate: 0h
>
> This was changed in CASSANDRA-16415 to include indications about queried vs
> fetched reagular & static columns. However, the result is used by
> {{AbstractReadQuery::toCQLString}}, which causes it to produce an illegal
> query string.
> This breaks a couple of dtests because they're looking for CQL strings in
> logs, which are no longer found:
> *
> {{upgrade_tests/paging_test.py::TestPagingWithDeletions::test_failure_threshold_deletions}}
> * {{cql_test.py::TestCQLSlowQuery}} has a couple of failing tests,
> {{test_local_query/test_remote_query}}
> We should also check audit and fql logs (and any other place where
> {{toCQLString}} is used.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
