[
https://issues.apache.org/jira/browse/CASSANDRA-16558?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17332532#comment-17332532
]
Ekaterina Dimitrova edited comment on CASSANDRA-16558 at 4/26/21, 3:48 PM:
---------------------------------------------------------------------------
{quote}I think we're going to keep having issues like this while rat-check is
run by default. Would running it only as part of CI not be enough?
{quote}
Then I am concerned we will have failing builds more often. Even if it is just
on the Jenkins dev...
What I am thinking is, maybe we can add some parameter (I think that sounds as
a good idea [~mck] ); make rat check mandatory but further to the report, also
to have a warning about that parameter that it can be used in cases like those
already mentioned.
The rat check is important if we want to keep our trunk always ready for a
release to be cut.
was (Author: e.dimitrova):
{quote}I think we're going to keep having issues like this while rat-check is
run by default. Would running it only as part of CI not be enough?
{quote}
Then I am concerned we will have failing builds more often. Even if it is just
on the dev branch...
What I am thinking is, maybe we can add some parameter (I think that sounds as
a good idea [~mck] ); make rat check mandatory but further to the report, also
to have a warning about that parameter that it can be used in cases like those
already mentioned.
The rat check is important if we want to keep our trunk always ready for a
release to be cut.
> Fix rat check (April 2021)
> --------------------------
>
> Key: CASSANDRA-16558
> URL: https://issues.apache.org/jira/browse/CASSANDRA-16558
> Project: Cassandra
> Issue Type: Task
> Components: Build, Packaging
> Reporter: Michael Semb Wever
> Assignee: Michael Semb Wever
> Priority: High
> Fix For: 2.2.20, 3.0.25, 3.11.11, 4.0, 4.0-rc1
>
> Attachments: Screenshot 2021-04-18 at 15.34.01.png
>
>
> The rat plugin in build.xml is a mess and not properly catching missing
> license headers.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
