[
https://issues.apache.org/jira/browse/CASSANDRA-16558?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17332567#comment-17332567
]
Ekaterina Dimitrova edited comment on CASSANDRA-16558 at 4/26/21, 4:27 PM:
---------------------------------------------------------------------------
bq. They would not fail due to untracked files on CI machines, though.
Yes, but they will fail in CI because someone didn't fail the build locally,
unfortunately :(
Just imagine a new contributor who haven't even heard of rat. The more this
could be automated and made easy for everyone (to be clear, the intention
wasn't to make people struggle and any feedback/PRs for improvement are more
than welcome!) experienced or not, the better IMHO
was (Author: e.dimitrova):
{quote}{quote} They would not fail due to untracked files on CI machines,
though.
{quote}{quote}
Yes, but they will fail in CI because someone didn't fail the build locally,
unfortunately :(
Just imagine a new contributor who haven't even heard of rat. The more this
could be automated and made easy for everyone (to be clear, the intention
wasn't to make people struggle and any feedback/PRs for improvement are more
than welcome!) experienced or not, the better IMHO
> Fix rat check (April 2021)
> --------------------------
>
> Key: CASSANDRA-16558
> URL: https://issues.apache.org/jira/browse/CASSANDRA-16558
> Project: Cassandra
> Issue Type: Task
> Components: Build, Packaging
> Reporter: Michael Semb Wever
> Assignee: Michael Semb Wever
> Priority: High
> Fix For: 2.2.20, 3.0.25, 3.11.11, 4.0, 4.0-rc1
>
> Attachments: Screenshot 2021-04-18 at 15.34.01.png
>
>
> The rat plugin in build.xml is a mess and not properly catching missing
> license headers.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
