[ https://issues.apache.org/jira/browse/CASSANDRA-16629?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17332539#comment-17332539 ]
Benjamin Lerer commented on CASSANDRA-16629: -------------------------------------------- {quote}should I migrate tests to assertj?{quote} We had a clear agreement on the mailing list on AssertJ. I do not know how Hamcrest was introduced. In my opinion we should standardize on AssertJ. Having to adapt to different test frameworks when working on a patch is a bit painful. > Rafactor tests for NodeTool commands > ------------------------------------ > > Key: CASSANDRA-16629 > URL: https://issues.apache.org/jira/browse/CASSANDRA-16629 > Project: Cassandra > Issue Type: Task > Components: Test/unit > Reporter: Alexey Zotov > Assignee: Alexey Zotov > Priority: Low > Fix For: 4.0.x > > Time Spent: 20m > Remaining Estimate: 0h > > h3. Overview > As a part of CASSANDRA-16404, I've been working on {{NodeTool}} commands for > invalidation of the auth caches. While working on that, I've mentioned that > the existing NodeTool unit tests are written in a different manner and reside > in wrong packages. I've made the following changes to them: > # moved them to the proper packages (that match original command class) > # unified naming, formatting, imports > # migrated from {{org.assertj}} to {{hamcrest}} for assertions (though it is > not smth really required) > # made a general cleanup > PR: https://github.com/apache/cassandra/pull/982 -- This message was sent by Atlassian Jira (v8.3.4#803005) --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org