[
https://issues.apache.org/jira/browse/CASSANDRA-16629?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17332719#comment-17332719
]
Alexey Zotov commented on CASSANDRA-16629:
------------------------------------------
{quote}I do not know how Hamcrest was introduced.
{quote}
Not sure, but most of the {{NodeTool}} tests were Hamcrest-based. That's why
originally I converted the rest from AssertJ to Hamcrest. Since now it is clear
that AssertJ is preferable, I've converted all tests to AssertJ. Looking
forward for review comments.
Thanks for providing a great support!
> Rafactor tests for NodeTool commands
> ------------------------------------
>
> Key: CASSANDRA-16629
> URL: https://issues.apache.org/jira/browse/CASSANDRA-16629
> Project: Cassandra
> Issue Type: Task
> Components: Test/unit
> Reporter: Alexey Zotov
> Assignee: Alexey Zotov
> Priority: Low
> Fix For: 4.0.x
>
> Time Spent: 20m
> Remaining Estimate: 0h
>
> h3. Overview
> As a part of CASSANDRA-16404, I've been working on {{NodeTool}} commands for
> invalidation of the auth caches. While working on that, I've mentioned that
> the existing NodeTool unit tests are written in a different manner and reside
> in wrong packages. I've made the following changes to them:
> # moved them to the proper packages (that match original command class)
> # unified naming, formatting, imports
> # migrated from {{org.assertj}} to {{hamcrest}} for assertions (though it is
> not smth really required)
> # made a general cleanup
> PR: https://github.com/apache/cassandra/pull/982
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
