[
https://issues.apache.org/jira/browse/CASSANDRA-16871?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17404116#comment-17404116
]
Ekaterina Dimitrova commented on CASSANDRA-16871:
-------------------------------------------------
Looks neat and I like all the verification.
I would make a point that config.yml is actually the lowres as I saw people
being confused about that.
One thing, if you are using higher resources and later in time you decide also
to change any of the environment variables, we should make it clear that
running only
.circleci/generate.sh
will return people to default low resources with the new variables. If they
want to keep the new resources they should use a flag again. Someone new might
get confused. I will look at it again in detail but on a quick check that is on
top of my mind. Thanks
> Add resource flags to CircleCi config generation script
> -------------------------------------------------------
>
> Key: CASSANDRA-16871
> URL: https://issues.apache.org/jira/browse/CASSANDRA-16871
> Project: Cassandra
> Issue Type: Task
> Components: CI
> Reporter: Andres de la Peña
> Assignee: Andres de la Peña
> Priority: Low
>
> Currently we have three versions of the CircleCI config file using different
> resources. Changing the resources configuration is as easy as copying the
> desired template file, for example:
> {code}
> cp .circleci/config.yml.MIDRES .circleci/config.yml
> {code}
> If we want to make changes to the file, for example to set a specific dtest
> repo or running the test multiplexer, we can run the provided generation
> script, copy the template file and probably exclude the additional changes:
> {code}
> # edit config-2_1.yml
> .circleci/generate.sh
> cp .circleci/config.yml.MIDRES .circleci/config.yml
> # undo the changes in config.yml.LOWRES, config.yml.MIDRES and
> config.yml.HIGHRES
> {code}
> A very common alternative to this is just editing the environment variables
> in the automatically generated {{config.yml}} file, which are repeated some
> 19 times across the file:
> {code}
> cp .circleci/config.yml.MIDRES .circleci/config.yml
> # edit config.yml, where env vars are repeated
> {code}
> I think we could do this slightly easier by adding a set of flags to the
> generation script to apply the resources patch directly to {{config.yml}},
> without changing the templates:
> {code}
> # edit config-2_1.yml
> .circleci/generate.sh -m
> {code}
> This has the advantage of not requiring manually editing the automatically
> generated file and also providing some validation.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
