[
https://issues.apache.org/jira/browse/CASSANDRA-16871?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17408203#comment-17408203
]
Andres de la Peña commented on CASSANDRA-16871:
-----------------------------------------------
Thanks for the review.
Committed to 3.0 as
[e4b37c3271c0e91407816d3c5370ebc8b95a615a|https://github.com/apache/cassandra/commit/e4b37c3271c0e91407816d3c5370ebc8b95a615a]
and merged to
[3.11|https://github.com/apache/cassandra/commit/595596e5eec74709c00a5876361262e680a7ab09],
[4.0|https://github.com/apache/cassandra/commit/b5e138646b7c67c6942c1be979c76ebba01c2cfa]
and
[trunk|https://github.com/apache/cassandra/commit/3d4397a6d114db9f0203149e5feaea23b016db06].
> Add resource flags to CircleCi config generation script
> -------------------------------------------------------
>
> Key: CASSANDRA-16871
> URL: https://issues.apache.org/jira/browse/CASSANDRA-16871
> Project: Cassandra
> Issue Type: Task
> Components: CI
> Reporter: Andres de la Peña
> Assignee: Andres de la Peña
> Priority: Low
> Fix For: 3.0.x, 3.11.x, 4.0.x, 4.x
>
>
> Currently we have three versions of the CircleCI config file using different
> resources. Changing the resources configuration is as easy as copying the
> desired template file, for example:
> {code}
> cp .circleci/config.yml.MIDRES .circleci/config.yml
> {code}
> If we want to make changes to the file, for example to set a specific dtest
> repo or running the test multiplexer, we can run the provided generation
> script, copy the template file and probably exclude the additional changes:
> {code}
> # edit config-2_1.yml
> .circleci/generate.sh
> cp .circleci/config.yml.MIDRES .circleci/config.yml
> # undo the changes in config.yml.LOWRES, config.yml.MIDRES and
> config.yml.HIGHRES
> {code}
> A very common alternative to this is just editing the environment variables
> in the automatically generated {{config.yml}} file, which are repeated some
> 19 times across the file:
> {code}
> cp .circleci/config.yml.MIDRES .circleci/config.yml
> # edit config.yml, where env vars are repeated
> {code}
> I think we could do this slightly easier by adding a set of flags to the
> generation script to apply the resources patch directly to {{config.yml}},
> without changing the templates:
> {code}
> # edit config-2_1.yml
> .circleci/generate.sh -m
> {code}
> This has the advantage of not requiring manually editing the automatically
> generated file and also providing some validation.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
