[ https://issues.apache.org/jira/browse/CASSANDRA-16806?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17405692#comment-17405692 ]
Benjamin Lerer commented on CASSANDRA-16806: -------------------------------------------- [~azotcsit] The current design of {{VirtualTable}} allow the person implementing it to easily convert its internal data (that are usually String and Numbers) into some Partitions and Rows through the use of a {{SimpleDataSet}}. The current code of {{AbstractWritableVirtualTable}} is good but force every person implementing it to have to deal with the conversion from the Cassandra objects to some internal data. An example of it is the unit test where a big part of the new code is conversion code. It would be nice if the patch could provide that conversion layer, in a similar way to what was done with {{SimpleDataSet}}. What do you think? > Allow DELETE and TRUNCATE to work on Virtual Tables if the implementation > allows it > ----------------------------------------------------------------------------------- > > Key: CASSANDRA-16806 > URL: https://issues.apache.org/jira/browse/CASSANDRA-16806 > Project: Cassandra > Issue Type: Improvement > Components: Feature/Virtual Tables > Reporter: Benjamin Lerer > Assignee: Aleksei Zotov > Priority: Normal > Fix For: 4.x > > Time Spent: 1h 20m > Remaining Estimate: 0h > > {{TRUNCATE}} statements are currently not supported by Virtual Tables. For > some Virtual Tables it makes sense to allow it. > It can be done by adding a {{truncate}} method to the {{VirtualTable}} > interface and calling that method from {{TruncateStatement}}. The default > implementation of the method should be to fire an {{InvalidRequestException}} > saying that truncate is not supported on that specific table. -- This message was sent by Atlassian Jira (v8.3.4#803005) --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org