[ 
https://issues.apache.org/jira/browse/CASSANDRA-16806?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17416174#comment-17416174
 ] 

Benjamin Lerer commented on CASSANDRA-16806:
--------------------------------------------

Sorry, for the delay [~azotcsit] while looking into the patch I realized that I 
forgot about multi-column restrictions. I added some tests and unfortunately 
the current logic for range deletion could not work on some of the scenarios 
(e.g. {{c1 >= 1 AND (c1, c2) <= (2, 3)}}). I reworked the patch to solve that 
problem and ended up refactoring different part of it. The changes are 
[here|https://github.com/apache/cassandra/compare/trunk...blerer:CASSANDRA-16806-review?expand=1].
 Tell me if those changes make sense to you. 

> Allow DELETE and TRUNCATE to work on Virtual Tables if the implementation 
> allows it
> -----------------------------------------------------------------------------------
>
>                 Key: CASSANDRA-16806
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-16806
>             Project: Cassandra
>          Issue Type: Improvement
>          Components: Feature/Virtual Tables
>            Reporter: Benjamin Lerer
>            Assignee: Aleksei Zotov
>            Priority: Normal
>             Fix For: 4.x
>
>          Time Spent: 4h
>  Remaining Estimate: 0h
>
> {{TRUNCATE}} statements are currently not supported by Virtual Tables. For 
> some Virtual Tables it makes sense to allow it.
> It can be done by adding a {{truncate}} method to the {{VirtualTable}} 
> interface and calling that method from {{TruncateStatement}}. The default 
> implementation of the method should be to fire an {{InvalidRequestException}} 
> saying that truncate is not supported on that specific table.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org

Reply via email to