[
https://issues.apache.org/jira/browse/CASSANDRA-16886?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17411030#comment-17411030
]
Benjamin Lerer commented on CASSANDRA-16886:
--------------------------------------------
The patch look good to me. The only nit I have is regarding the use of numeric
values for bytes to/from MB converversions.
Even if we rely on CASSANDRA-15234 to fix that later on we should probably use
{{org.apache.cassandra.io.util.FileUtils.ONE_MB}} instead of {{1048576}}. An
other optrion would be to use {{ByteUnit}} and add a {{fromBytes}} method to
it.
> Reduce native_transport_max_frame_size_in_mb
> --------------------------------------------
>
> Key: CASSANDRA-16886
> URL: https://issues.apache.org/jira/browse/CASSANDRA-16886
> Project: Cassandra
> Issue Type: Improvement
> Components: Messaging/Client
> Reporter: Brandon Williams
> Assignee: Brandon Williams
> Priority: Normal
>
> There is really no point in having this set to 256MB when the commitlog
> segment size defaults to 32MB, effectively capping the largest insertable
> mutation to 16MB.
> The native transport can provide a good first line of defense against large
> mutations that would otherwise hit the heap if left to be rejected by the
> commitlog.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
