[ https://issues.apache.org/jira/browse/CASSANDRA-16886?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17411377#comment-17411377 ]
Brandon Williams commented on CASSANDRA-16886: ---------------------------------------------- bq. The only nit I have is regarding the use of numeric values This bothered me when writing it, but there are many other places in DD where 1048576 specifically is used for this purpose, so I decided to keep the same style and let CASSANDRA-15234 sort it out later. I'm not sure if doing it differently really furthers the goal of clealiness, and I didn't want to refactor all of the instances in this patch, but I can switch to ByteUnit here if you prefer. > Reduce native_transport_max_frame_size_in_mb > -------------------------------------------- > > Key: CASSANDRA-16886 > URL: https://issues.apache.org/jira/browse/CASSANDRA-16886 > Project: Cassandra > Issue Type: Improvement > Components: Messaging/Client > Reporter: Brandon Williams > Assignee: Brandon Williams > Priority: Normal > > There is really no point in having this set to 256MB when the commitlog > segment size defaults to 32MB, effectively capping the largest insertable > mutation to 16MB. > The native transport can provide a good first line of defense against large > mutations that would otherwise hit the heap if left to be rejected by the > commitlog. -- This message was sent by Atlassian Jira (v8.3.4#803005) --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org